Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loki-build-image: Upgrade golangci-lint and Go #4028

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Jul 22, 2021

What this PR does / why we need it:
In loki-build-image Dockerfile, upgrade golangci-lint and Go.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Would like to see whether Loki will work with latest golangci-lint, fails for me locally.

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 requested a review from a team as a code owner July 22, 2021 11:49
@owen-d owen-d merged commit bd30921 into main Jul 22, 2021
@owen-d owen-d deleted the chore/upgrade-golangci-lint branch July 22, 2021 12:29
@owen-d owen-d mentioned this pull request Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants