Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min_sharding_lookback limits to the frontends #4047

Merged
merged 3 commits into from
Jul 26, 2021

Conversation

cyriltovena
Copy link
Contributor

This allows to skip sharding for recent time range. For example if the value is set to 1h,
all queries for the given tenant that are between now and now-1h are not sharded.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyriltovena cyriltovena merged commit 3f3d10a into grafana:main Jul 26, 2021
cyriltovena added a commit that referenced this pull request Jul 26, 2021
* Add min_sharding_lookback limits to the frontends

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* improve doc.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* lint

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena added a commit that referenced this pull request Jul 26, 2021
* Add min_sharding_lookback limits to the frontends

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* improve doc.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* lint

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena added a commit that referenced this pull request Jul 26, 2021
* Add min_sharding_lookback limits to the frontends

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* improve doc.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* lint

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
KMiller-Grafana added a commit to KMiller-Grafana/loki that referenced this pull request Jul 26, 2021
owen-d added a commit that referenced this pull request Jul 27, 2021
* Clarify prose about querier frontend min-sharding-lookback

Docs edit of prose from #4047.

* Update docs/sources/configuration/_index.md

Co-authored-by: Danny Kopping <dannykopping@gmail.com>

Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
Co-authored-by: Danny Kopping <dannykopping@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants