-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support frontend V2 with query scheduler. #4071
Conversation
b059ff4
to
b6acea4
Compare
b6acea4
to
39224ce
Compare
grpc_client_config: | ||
max_send_msg_size: 1.048576e+08 | ||
parallelism: 6 | ||
scheduler_address: query-scheduler:9009 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether this is a duplicate of -querier.scheduler-address
in the Docker compose file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-querier.scheduler-address takes precedence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good I think we should also integrate a new module for the query-scheduler so that we only use Loki docker image.
I'd love to see also a follow up PR to update our jsonnet.
@cyriltovena, do you mean for production or for examples? |
In the production folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just one small change is required.
What this PR does / why we need it:
This enables the configuration of a query scheduler to scale out queries further. The query frontend and querier can be passed a
scheduler-address
now. The scheduler itself can be the Cortex process.See https://cortexmetrics.io/docs/operations/scaling-query-frontend/ for more details.
Checklist