Make log query results cacheable #4095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to splitting so that each intervals query can be cached. Signed-off-by: Callum Styan <callumstyan@gmail.com>
|
|
cyriltovena
reviewed
Aug 4, 2021
cyriltovena
reviewed
Aug 4, 2021
Signed-off-by: Callum Styan <callumstyan@gmail.com>
alignment logic into the splitter for that query type. Signed-off-by: Callum Styan <callumstyan@gmail.com>
cyriltovena
added
the
keepalive
|
I'm still interested into this. Adding the keepalive tag. |
cyriltovena
reviewed
Sep 16, 2021
cyriltovena
reviewed
Sep 16, 2021
cyriltovena
reviewed
Sep 16, 2021
Signed-off-by: Callum Styan <callumstyan@gmail.com>
|
Drone build seems to be stuck and I don't have admin access for this repo. |
cstyan
changed the title
Signed-off-by: Callum Styan <callumstyan@gmail.com>
|
I think we should do this for all query types. @cstyan do you mind if I push to your branch or open a new PR which would also cover your changes? |
|
Closing this as no activities for long time. Feel free to send new PR if anyone want's to revive the work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns a queries time range to multiples of the split-by interval prior to splitting so that each intervals query result can be cached. Note that the first and last interval are later changed again to use the original start and end time of the query so that we're not.
Signed-off-by: Callum Styan callumstyan@gmail.com