Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonnet: Add Grafana Enterprise Logs library #4165

Merged
merged 16 commits into from
Aug 17, 2021
Merged

Jsonnet: Add Grafana Enterprise Logs library #4165

merged 16 commits into from
Aug 17, 2021

Conversation

jdbaldry
Copy link
Member

What this PR does / why we need it:
This PR adds a Grafana Enterprise Logs Jsonnet library that extends the OSS Loki library.

Special notes for your reviewer:

  • This PR includes rudimentary testing that can be performed with $ make test, this essentially only proves that Tanka is able to evaluate the Jsonnet.
  • This has been evaluated against a working dev cluster and produces minimal (and desirable) diffs over what is currently deployed internally.
  • Documentation is separate and will be released in the GEL setup docs
  • There are some TODOs noted at the top of the library file. These represent task that I would ideally like to contribute to the OSS Loki chart and inherit.

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry requested a review from a team as a code owner August 13, 2021 15:51
@jdbaldry
Copy link
Member Author

@pull-request-size pull-request-size bot added the size/XL label 7 minutes ago

Nice!

@jdbaldry jdbaldry closed this Aug 13, 2021
@jdbaldry jdbaldry reopened this Aug 13, 2021
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@slim-bean slim-bean merged commit f381264 into main Aug 17, 2021
@slim-bean slim-bean deleted the jdb/gel-jsonnet branch August 17, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants