Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Add darwin/arm64 build to release binaries #4189

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

mathew-fleisch
Copy link
Contributor

No description provided.

@mathew-fleisch mathew-fleisch requested a review from a team as a code owner August 18, 2021 17:05
@CLAassistant
Copy link

CLAassistant commented Aug 18, 2021

CLA assistant check
All committers have signed the CLA.

@stale
Copy link

stale bot commented Sep 19, 2021

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Sep 19, 2021
@mathew-fleisch
Copy link
Contributor Author

mathew-fleisch commented Sep 22, 2021

Can someone look at and respond to my PR?

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Sep 22, 2021
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay! Wonderful change, thank you :)

@owen-d owen-d merged commit 895165f into grafana:main Sep 28, 2021
@mathew-fleisch
Copy link
Contributor Author

Thanks @owen-d I wanted to make this change so the asdf-plugin for loki-logcli would install the correct binary for each host system. Check out the asdf version manager project if you don't already know about it. One problem I see with this change is that there will only be darwin-arm64 binaries for the next version and beyond. I don't know of a way to go back to each previous version and backfill darwin-arm64 binaries for previous versions. If you have any thoughts or suggestions, it would be nice to have, but this is already great to get in there as is. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants