Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Kubernetes service discovery configuration. #4206

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

jeschkies
Copy link
Contributor

What this PR does / why we need it:
We have two sections on the Kubernetes service discovery in Promtail. This change links from scraping/#kubernetes-discovery to configuration/#kubernetes_sd_config.

Checklist

  • Documentation added

Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

A nit-pick: config is not a word. Configure is the verb. Configuration is the noun. Use of config is common in the Loki doc set, so I won't hold up this PR or ask you to change this instance.

@owen-d owen-d merged commit 29d2394 into grafana:main Aug 24, 2021
@jeschkies jeschkies deleted the karsten/link-kubernetes-sd branch December 14, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants