Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAL replay discard metrics #4212

Merged
merged 2 commits into from
Aug 24, 2021
Merged

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Aug 24, 2021

As the WAL replays segments on top of checkpoints, it's common to confront duplicate data. This PR adds metrics for how much data is discarded this way during a replay.

@owen-d owen-d requested a review from a team as a code owner August 24, 2021 13:26
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit abcf4d0 into grafana:main Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants