cli: Register configuration option store.max-look-back-period as CLI argument
#4242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chaudum
force-pushed
the
chaudum/register-config-options
branch
from
546c817
to
f9c98d6
Compare
chaudum
changed the title
store.chunks-cache.max-look-back-period and querier.split-queries-by-interval as CLI argumentsstore.max-look-back-period as CLI arguments
chaudum
changed the title
store.max-look-back-period as CLI argumentsstore.max-look-back-period as CLI argument
Even though the flag is already deprecated, registering the flag is necessary for generating the config reference documentation.
chaudum
force-pushed
the
chaudum/register-config-options
branch
from
01e756e
to
6770f22
Compare
|
@owen-d Not sure why CI fails |
owen-d
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As the title suggests, this PR register a (deprecated) configuration option as CLI argument.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This will help towards auto-generating reference documentation from source.
Checklist