Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonnet: Update license path argument name #4259

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Conversation

eamonryan
Copy link
Member

What this PR does / why we need it:
The argument name for the license path has changed. It used to be bootstrap.license.path but has been updated to license.path (per the GEM documentation, wherein GEL likely inherits the same code). Without this change, the Jsonnet will deploy a GEL cluster that fails to find the license, causing the admin-api to fail to start and the gateway to also be unlicensed.

Which issue(s) this PR fixes:
Fixes #4258

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@eamonryan eamonryan requested a review from a team as a code owner September 1, 2021 19:52
@CLAassistant
Copy link

CLAassistant commented Sep 1, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@owen-d owen-d merged commit 58219ff into main Sep 7, 2021
@owen-d owen-d deleted the fix-license-path-arg branch September 7, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploying GEL via the Jsonnet library results in license not being found
4 participants