Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix #4308 into k62 #4322

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Hotfix #4308 into k62 #4322

merged 1 commit into from
Sep 13, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Sep 13, 2021

@cyriltovena @owen-d
Fixes the pattern parser validation. (grafana#4308)
b4c8ffc 
We should never have 2 consecutive capture, since when we do we can't figure which data goes where.
The previous validation was validating two nodes at the time and moving to the next two nodes so in the end it wasn't validating properly.

:facepalm:

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@owen-d owen-d requested a review from a team as a code owner September 13, 2021 20:25
slim-bean
slim-bean approved these changes Sep 13, 2021
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit d40814b into grafana:k62 Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@owen-d @slim-bean @cyriltovena