Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruler: adding pkg/metrics from agent #4354

Merged
merged 3 commits into from
Sep 20, 2021

Conversation

dannykopping
Copy link
Contributor

What this PR does / why we need it:
We need this code as a prerequisite for #4344.

Significant changes have been made to this code, and the best way to show those is to merge this first and then rebase #4344.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
Many tests will break. This is expected, and will be corrected in #4344.

Checklist

  • Documentation added
  • Tests updated

Danny Kopping added 3 commits September 20, 2021 10:33
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
@dannykopping dannykopping marked this pull request as ready for review September 20, 2021 08:56
@dannykopping dannykopping requested a review from a team as a code owner September 20, 2021 08:56
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannykopping dannykopping merged commit eef896c into grafana:main Sep 20, 2021
@dannykopping dannykopping deleted the dannykopping/agent-wal-code branch September 20, 2021 13:11
@dannykopping dannykopping mentioned this pull request Sep 20, 2021
2 tasks
dannykopping pushed a commit that referenced this pull request Sep 27, 2021
* Adding pkg/metrics from agent

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>

* Adding notice to all copied files

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>

* Adding two utility files that are needed as well

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants