Add more tests around config parsing changes from common config PR #4433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trevorwhitney can we name this PR a little more descriptively please? We use the PR names for our changelogs |
trevorwhitney
changed the title
|
@dannykopping yes, absolutely, sorry I didn't mean to actually name it after that terrible commit! |
Haha no sweat! Thanks 🙌 |
trevorwhitney
changed the title
trevorwhitney
force-pushed
the
populate-memberlist
branch
from
bdc07d1
to
f4a68c4
Compare
|
Going to wait on resolving conflicts until #4400 is merged as this builds on that branch |
Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com>
Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com>
Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com>
…here Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com>
Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com>
trevorwhitney
force-pushed
the
config-parse-bug-fix-2
branch
from
eed3ee7
to
0078ec6
Compare
Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com>
|
@dannykopping this should be good to go now, would you mind merging if you have permission to do so? |
|
You got it 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a bit more testing around the new config unmarshalling methods to confirm #4419 was not a real bug. It turned out just to be a strange behavior when passing a completely empty yaml file as the config file, like:
This was being used for tests, but is unlikely a case we need to solve for in real usage.
Which issue(s) this PR fixes:
Fixes #4419
Checklist