Loki: Override distributor's default ring KV store #4440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanGuedes
changed the title
2 tasks
DylanGuedes
force-pushed
the
use-inmemory-as-default-kvstore
branch
from
e068f84
to
e5045f9
Compare
There was a problem hiding this comment.
@DylanGuedes this looks good, will conflict with #4435 but should be easy to resolve. If your ready to publish I think it's good to go.
Awesome! I added an entry to the CHANGELOG and to the upgrading guide so now it is ready for review. :D edit: and yeah, once #4435 gets merged I'll rewrite the tests on this one |
DylanGuedes
force-pushed
the
use-inmemory-as-default-kvstore
branch
from
58ff6bc
to
b1a43a0
Compare
trevorwhitney
approved these changes
Oct 8, 2021
kavirajk
approved these changes
Oct 11, 2021
|
@DylanGuedes I'll merge this once the conflicts have been resolved |
|
Looks like @slim-bean have some opinion on it. We will hold off the merge! |
DylanGuedes
force-pushed
the
use-inmemory-as-default-kvstore
branch
3 times, most recently
from
91df8e7
to
04e0dbb
Compare
- Currently, the default KVstore is consul. This changes it to inmemory to make it easier for new users to run the project without dependencies. - Refactor default flag value tests. Now, it will check for a populated map instead of checking for flags during iteration.
DylanGuedes
force-pushed
the
use-inmemory-as-default-kvstore
branch
from
04e0dbb
to
d0a1a9b
Compare
|
Note: I rewrote the commit history because it was becoming weird after rebasing with the latest changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changes the default distributor ring KV store from
consultoinmemory. This change makes the Distributor easier to run with default configs by not requiring Consul.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Checklist