Loki: Change how push API checks for contentType #4443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Currently, the ContentType is expected to be exactly "application/json". That's a problem because although a "application/json; charset=utf-8" is considered a valid JSON content type, it will be seen as an error.
DylanGuedes
changed the title
- mime.ParseMediaType is more reliable than strings.Contains because if a wrong contentType (such as "application/jsonnn") is given, we still accept it - mime.ParseMediaType has support for contentType parameters. This way, valid contentTypes such as "application/json; charset=utf-8" will not be rejected
- Without this change, the lint fails because gzipString would be called
with always the same input. Full error:
```
`gzipString` - `source` always receives ``{"streams": [{ "stream": {
"foo": "bar2" }, "values": [ [ "1570818238000000000", "fizzbuzz" ] ]
}]}` ("{\"streams\": [{ \"stream\": { \"foo\": \"bar2\" }, \"values\": [
[ ...)
` (unparam)
```
dannykopping
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changes how the push API checks for contentType. Currently, the contentType is expected to be exactly
application/json, however, even other valid values such asapplication/json; charset=utf-8aren't accepted. In fact, Loki's response to that endpoint has contentTypeapplication/json; charset=utf-8so I think it is worth to support it.Which issue(s) this PR fixes:
Fixes #4442
Special notes for your reviewer:
Checklist