Add a a parameter to keep/drop the stream label from cloudwatch. #4494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callum Styan <callumstyan@gmail.com>
cyriltovena
reviewed
Oct 19, 2021
| if keep != "" && strings.EqualFold(keep, "true") { | ||
| keepStream = true | ||
| } | ||
| fmt.Println("keep stream: ", keepStream) |
There was a problem hiding this comment.
Should you keep this ?
There was a problem hiding this comment.
I think it's useful for users. It would only be printed once per execution of the lambda function, and is potentially the easiest way to find out the value for that option if they don't have easy access to the configuration/deployment of the lambda themselves.
cyriltovena
reviewed
Oct 19, 2021
cyriltovena
reviewed
Oct 19, 2021
cyriltovena
approved these changes
Oct 19, 2021
Signed-off-by: Callum Styan <callumstyan@gmail.com>
variable when deploying via CloudFormatioEnsure the keep stream value is properly passed in as an environment variable when deploying via CloudFormationn Signed-off-by: Callum Styan <callumstyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately there's no nice way to set a CLI argument for a Go lambda, so the toggling of keeping/dropping the stream label is via another environment variable that users can set in their terraform/cloudformation.
Signed-off-by: Callum Styan callumstyan@gmail.com