-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce overrides-exporter
module to Loki
#4520
Introduce overrides-exporter
module to Loki
#4520
Conversation
…est configs for local dev
@KMiller-Grafana QQ: any opinions on where to place new documentation for the |
overrides-exporter
module to Loki
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! A couple small notes
…est configs for local dev
ba1b254
to
55a37b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the reflection approach, personally. If security or cardinality becomes a concern, we could always add a denylist
or allowlist
mechanism to reduce them. I think the benefit of avoiding drift outweighs the potential risk here.
Pull/4520
What this PR does / why we need it:
This PR introduces a new module to Loki that will export tenant limits including overrides to further expand visibility into tenant configurations and behavior.
Examples runtime-config with overrides:
Running Loki with only the
overrides-exporter
target specified and a basicschema_config
:Exported metrics:
Which issue(s) this PR fixes:
Closes #4389
Special notes for your reviewer:
N/A
Checklist