Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only exports tenant limits which differ from defaults and export defa… #4542

Merged
merged 3 commits into from
Oct 26, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Oct 25, 2021

This improves the overrides-exporter by exporting the defaults under the metric loki_overrides_defaults as well as only exporting fields which differ for each tenant, dramatically reducing potential cardinality as we often override only a subset of fields.
image

…ults under `loki_overrides_defaults` metric.
@owen-d owen-d requested a review from a team as a code owner October 25, 2021 19:12
Copy link
Contributor

@JordanRushing JordanRushing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@owen-d owen-d merged commit a27aec3 into grafana:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants