Improve lambda-promtail docs based on Owens review. #4548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callum Styan <callumstyan@gmail.com>
cstyan
requested review from
dannykopping,
owen-d and
slim-bean
as code owners
owen-d
approved these changes
Oct 26, 2021
Signed-off-by: Callum Styan <callumstyan@gmail.com>
promtail pipeline stage.
owen-d
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes based on your comments on the other PR @owen-d
Let me know if the description on line 40 makes sense now, it's essentially to explain that in the terraform I've written doesn't allow the users to set filter pattern per log group if they pass all their log group names in via the array I've defined.
Signed-off-by: Callum Styan callumstyan@gmail.com