Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a panic in the labels API when no parameters are supplied. #4554

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

cyriltovena
Copy link
Contributor

We were supporting this before.

Fixes #4552

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

We were supporting this before.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyriltovena cyriltovena requested a review from a team as a code owner October 26, 2021 10:46
@cyriltovena cyriltovena changed the title Fixes the a panic in the labels API when no parameters are supplied. Fixes a panic in the labels API when no parameters are supplied. Oct 26, 2021
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 47336cd into grafana:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid memory address or nil pointer dereference during grpc labels request
3 participants