Loki: Add a ring to the compactor used to control concurrency when not running standalone #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slim-bean
requested review from
dannykopping,
owen-d and
a team
as code owners
slim-bean
commented
Oct 28, 2021
| All: {QueryScheduler, QueryFrontend, Querier, Ingester, Distributor, Ruler}, | ||
| Read: {QueryScheduler, QueryFrontend, Querier, Ruler}, | ||
| All: {QueryScheduler, QueryFrontend, Querier, Ingester, Distributor, Ruler, Compactor}, | ||
| Read: {QueryScheduler, QueryFrontend, Querier, Ruler, Compactor}, |
There was a problem hiding this comment.
Reasons for putting the compactor on the read path:
- having consistent performance on all write nodes is more critical than read nodes
- the compactor is a read path optimization and is not critical to writes
owen-d
reviewed
Oct 28, 2021
There was a problem hiding this comment.
Left a bunch of comments, but I think I'm fine with the compactor always depending on the ring, even when run with -target=scheduler. I believe it's worse to maintain two code paths and I suspect we'll eventually need it anyway for horizontally scalable compaction.
slim-bean
force-pushed
the
compactor-ring
branch
from
e4d098f
to
8fffd56
Compare
Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
…rings to persist tokens
…other than a scheduler in the future.
slim-bean
force-pushed
the
compactor-ring
branch
from
3619395
to
584a47c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To simplify operations, we want to enable a horizontally scalable "all" target as well as the new "read" "write" targets, without having to run a separate compactor.
This PR adds a ring to the compactor which is used for leader election by looking to see which instance has a specific key in the ring.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist