Ignore validity window during wal replay #4596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slim-bean
reviewed
Oct 29, 2021
| _, err = s.Push(context.Background(), entries, recordPool.GetRecord(), 0) | ||
| require.NotNil(t, err) | ||
|
|
||
| // Now pretend it's a replay. The same write should succeed. |
There was a problem hiding this comment.
thank you for these comments, very helpful!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a possible bug that could occur when moving from
ingester.max-chunk-age=x->ingester.max-chunk-age=ywherey < x. Themax-chunk-ageparameterizes how far behind incoming writes are allowed to be and decreasing this validity window then replaying an existing WAL could result in dropped data during recovery. This PR ensures that previously accepted data in the WAL will be accepted during replay, even after the validity window is lowered.