add date time sprig template functions in logql label/line formatter #4603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettlish
requested review from
dannykopping,
owen-d and
slim-bean
as code owners
garrettlish
force-pushed
the
main
branch
4 times, most recently
from
8231545
to
f50edb2
Compare
sandeepsukhani
approved these changes
Nov 1, 2021
kavirajk
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
Looks nice 👍 Thanks @garrettlish. Left one minor suggestions.
And can you also please update the ``CHANGELOG.md`?
|
|
||
| ## date | ||
|
|
||
| `date` returns a textual representation of the time value formatted according to layout. |
There was a problem hiding this comment.
Q: about the layout. Can we explain bit about it? What are the other options? (is it same as golang's datetime layout?, if yes, we can mention that and refer the doc to the layout?)
There was a problem hiding this comment.
This is a good question. I'm not actually sure, although I expected it was the same as golang's.
There was a problem hiding this comment.
Yes, you are correct, it is golang datetime layout, added doc references to the layout - a4aa5e7
There was a problem hiding this comment.
Cool. thanks for adding the the clarification! 👍
With date time sprig template functions, we will be able to filter test jobs which create time is 1 day before as the following:
```
{job="test"} | label_format nowEpoch=`{{(unixEpoch now)}}`,createDateEpoch=`{{unixEpoch (toDate "2006-01-02" .createDate)}}` | label_format dateTimeDiff="{{sub .nowEpoch .createDateEpoch}}" | dateTimeDiff > 86400
```
* add golang datetime layout doc reference * update CHANGELOG.md accordingly to include this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introduce date time sprig template functions in logql label/line formatter, it allows us to get current time, format date time and parse date time with specified layout.
Which issue(s) this PR fixes:
Fixes #4511, we will be able to filter test jobs which create time is 1 day before as the following:
Special notes for your reviewer:
N/A
Checklist