Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promtail: Fix replace missing adjacent capture groups #4874

Conversation

Alan01252
Copy link
Contributor

What this PR does / why we need it:
This fixes a bug where adjacent capture groups are not replaced properly.

Which issue(s) this PR fixes:
Fixes #4870

Checklist

  • Documentation added
  • [X ] Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

@Alan01252 Alan01252 requested a review from a team as a code owner December 3, 2021 21:41
@CLAassistant
Copy link

CLAassistant commented Dec 3, 2021

CLA assistant check)
All committers have signed the CLA.

@Alan01252 Alan01252 force-pushed the fix/promtail_replace_adjacent_capture_groups branch from 8c45d32 to 68709d6 Compare December 3, 2021 21:44
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 1e0b270 into grafana:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promtail "replace" stage not replacing all occurances.
3 participants