LogQL: add __line__ function to | line_format template #4879
Conversation
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
| buf: bytes.NewBuffer(make([]byte, 4096)), | ||
| } | ||
| functionMap[functionLineName] = func() string { | ||
| return unsafeGetString(lf.currentLine) |
There was a problem hiding this comment.
I can add a test for the race but I think it's fine
There was a problem hiding this comment.
Well let me rephrase that, it's not thread safe but this whole code of LogQL is never run multiple line at a time.
There was a problem hiding this comment.
We can have multiple querier workers which can call this concurrently, no?
There was a problem hiding this comment.
Each worker initialized this once and execute it line by line.
There was a problem hiding this comment.
I think we're good @owen-d, I can try it in dev if that would make you more confident.
There was a problem hiding this comment.
functionMap is globally defined variable, so even if we have multiple workers, this looks like a problem. Am I missing something?
There was a problem hiding this comment.
Ho yeah I was focused on something else the log line, I need to copy this map fn
There was a problem hiding this comment.
Good call it's cloned !
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
|
@owen-d we should be good now, can you confirm and merge ? |
This PRs introduce a new
__line__function for the LogQLline_formatpipeline.This function returns the current log line in case the users wants to enrich it.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com
Which issue(s) this PR fixes:
Fixes #4878
Checklist
CHANGELOG.mdabout the changes.