Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -list-targets command line flag #4920

Merged
merged 5 commits into from
Dec 13, 2021
Merged

Add -list-targets command line flag #4920

merged 5 commits into from
Dec 13, 2021

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Dec 13, 2021

What this PR does / why we need it:

The -list-targets flag can help users to understand with which targets Loki can be run. The targets also show which components a target consists of.

$ ./cmd/loki/loki -list-targets -config.file=config.yaml
all
  compactor
  distributor
  ingester
  ingester-querier
  querier
  query-frontend
  query-scheduler
  ruler
compactor
distributor
index-gateway
ingester
ingester-querier
overrides-exporter
querier
  ingester-querier
  query-scheduler
query-frontend
  query-scheduler
query-scheduler
read
  compactor
  ingester-querier
  querier
  query-frontend
  query-scheduler
  ruler
ruler
  ingester-querier
table-manager
write
  distributor
  ingester

Which issue(s) this PR fixes:
Fixes #4912

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

@chaudum
Add -list-targets flag to list available targets
9a0fae6 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum
Mark user-invisible modules as such
71ee8e6 
so they are not shown as run targets when listing available targets
using the `-list-targets` flag.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum
Mention command line flag in configuration docs
47ca6bc 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum
Add changelog entry
91a6cef 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum changed the title Chaudum/list targets Add -list-targets command line flag Dec 13, 2021
@chaudum
fixup! Add -list-targets flag to list available targets
a1fb33e 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum marked this pull request as ready for review December 13, 2021 13:17
@chaudum chaudum requested review from KMiller-Grafana and a team as code owners December 13, 2021 13:17
dannykopping
dannykopping approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👌

@dannykopping dannykopping merged commit feb5d71 into main Dec 13, 2021
@dannykopping dannykopping deleted the chaudum/list-targets branch December 13, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@KMiller-Grafana KMiller-Grafana Awaiting requested review from KMiller-Grafana

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add -modules CLI flag to list available targets
2 participants
@chaudum @dannykopping