Provide optional matchers to LabelValuesForMetricName.
#4933
Conversation
jeschkies
force-pushed
the
karsten/lbac
branch
from
e6ba855
to
81f2a64
Compare
| fooChunk1, | ||
| fooChunk2, | ||
| }); err != nil { | ||
| t.Fatal(err) |
There was a problem hiding this comment.
This test was copied from chunk_store_test.go but fails with series_store_test.go:70: table not found: cortex_chunks2710. Not sure what's going on.
|
The test passes when run individually. However, it fails when all tests are run together. The Just checked. If the test runs at the beginning by renaming it |
| mtime.NowForce(baseTime) | ||
| defer mtime.NowReset() |
There was a problem hiding this comment.
Ok, this was nasty. Could we inject a time interface instead similar to injecting a logger?
| if err != nil { | ||
| return nil, err | ||
| } | ||
| seriesIDsSet := make(map[string]struct{}, len(seriesIDs)) |
There was a problem hiding this comment.
nit: not sure using a map will be better. We can take a look at this later.
Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
What this PR does / why we need it:
In some cases we want to fetch label values from a limited set of series. This can be done by passing label matchers for the series to the
LabelValuesForMetricNamemethod. The matchers are applied first to filter out all chunk ids that matcher all of them. Then we fetch all label values and filter out those that are part of the chunks.Checklist
CHANGELOG.mdabout the changes.