Add distributor ring page #4938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavirajk
reviewed
Dec 16, 2021
pkg/distributor/http.go
Outdated
| <p>Not running with Global Rating Limit - ring not being used by the Distributor.</p> | ||
| </body> | ||
| </html>` | ||
| cortex_util.WriteHTMLResponse(w, noRingPage) |
There was a problem hiding this comment.
@DylanGuedes Can you please copy the WriteHTMLResponse to our loki's util package and use that instead?
Rationale is to avoid introducing anymore dependency from Cortex. Also we are trying to remove existing dependencies incrementally.
Particularly this PR tries to remove cortex/util package dependency completely.
There was a problem hiding this comment.
Oops, good catch! I just pushed a new commit fixing that, lmk what you think.
|
Need a lint on the new util. |
KMiller-Grafana
previously requested changes
Dec 23, 2021
owen-d
approved these changes
Jan 3, 2022
- This new IngestionRateStrat is used internally to represent the chosen ingestion rate strategy, to avoid using plain strings.
As of now, the distributor only has a pointer to its lifecycler. Since the ring HTTP handler isn't implemented for the lifecycler but it is for the ruler, this extends the distributor by also holding a ring instance.
DylanGuedes
force-pushed
the
add-distributor-ring-page
branch
from
0dbb7f1
to
d0f2417
Compare
4 tasks
DylanGuedes
added a commit
that referenced
this pull request
Jul 11, 2022
Removes the ring client from the distributor. - It was originally added on PR #4938 because it was the only ring implementation with HTTPHandler support (used for the ring page). Now that DSKit has support for the other ring implementations (including the lifecycler) this isn't necessary anymore. - It had an IgnoreUnhealthyInstancesReplicationStrategy attached to it, added by mistake
lxwzy
pushed a commit
to lxwzy/loki
that referenced
this pull request
Nov 7, 2022
Removes the ring client from the distributor. - It was originally added on PR grafana#4938 because it was the only ring implementation with HTTPHandler support (used for the ring page). Now that DSKit has support for the other ring implementations (including the lifecycler) this isn't necessary anymore. - It had an IgnoreUnhealthyInstancesReplicationStrategy attached to it, added by mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
distributorsRingtodistributorsLifecyclerto avoid misleadWhich issue(s) this PR fixes:
Fixes #4937
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.