Start refactor of storage (chunks) clients metrics into structs #5057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struct), add an azure client metric for total egress bytes. Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
kavirajk
approved these changes
Jan 6, 2022
|
|
||
| // Unregister unregisters the blob storage metrics with the prometheus default registerer, useful for tests | ||
| // where we frequently need to create multiple instances of the metrics struct, but not globally. | ||
| func (bm *BlobStorageMetrics) Unregister() { |
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
cstyan
changed the title
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
owen-d
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started a refactor of metrics for each of our chunks storage clients, which can be continued in follow up PRs. Ideally, we should try to avoid package global metrics that are registered via package
initfunctions. Here I've added anBlobStorageMetricsstruct in the azure package, and aClientsMetricstruct. The latter will eventually contain one of each chunk client implementations metrics structs. I'll also likely modify each so that the registerer can be passed in as well, rather than always using the default prometheus registerer. Maybe this is just personal preference but setting metrics up this way feels cleaner to me. It also makes reuse of these packages within other projects easier.Signed-off-by: Callum Styan callumstyan@gmail.com