Fix deadlock in disconnecting querier #5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
| defer cancel() | ||
|
|
||
| // We use random port here, hopefully without any gRPC server. | ||
| cc, err := grpc.DialContext(ctx, "localhost:999", grpc.WithInsecure()) |
There was a problem hiding this comment.
Any reason to not use the mechanism used in the frontend_test.go for getting a random port to guarantee no existing server?
l, err := net.Listen("tcp", "")
require.NoError(t, err)
server := grpc.NewServer()
h, p, err := net.SplitHostPort(l.Addr().String())
require.NoError(t, err)
There was a problem hiding this comment.
To be honest the best is to use in-memory grpc server. I'll swap this for it.
There was a problem hiding this comment.
using google.golang.org/grpc/test/bufconn I'll send a commit to show you.
Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a race condition between the broadcast triggered by the
canceled context and the condition waiting: if the broadcast happend
before the wait, wait never receives any broadcast.
I also ported back all tests missing from the code we forked.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com