Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki: Implement custom /config handler (#4785) #5078

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

ssncferreira
Copy link
Contributor

What this PR does / why we need it:

Backports #4785 to 2.4 release branch in preparation for 2.4.2. This is required for GEL 1.3 for bugfix: https://github.com/grafana/loki-enterprise/pull/364

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

* Implement custom /config handler.

* Make `customConfigEndpointHandlerFn` public.
@ssncferreira ssncferreira requested a review from a team as a code owner January 7, 2022 19:09
@slim-bean slim-bean merged commit db15f8e into release-2.4 Jan 7, 2022
@slim-bean slim-bean deleted the backport-4785-release-2.4 branch January 7, 2022 19:26
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants