Auto-expire old items from FIFO cache #5148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Jan 17, 2022
cyriltovena
reviewed
Jan 17, 2022
cyriltovena
approved these changes
Jan 17, 2022
chaudum
force-pushed
the
chaudum/remove-validity-from-fifo
branch
from
3fa4ff5
to
cf120f0
Compare
|
@cyriltovena I've moved the ticker creation into the goroutine. Do you want to have another look? |
cyriltovena
reviewed
Jan 18, 2022
cyriltovena
reviewed
Jan 18, 2022
Let's wait for @KMiller-Grafana and I'll merge it. |
sandeepsukhani
approved these changes
Jan 18, 2022
|
Very nice! thanks for adding this @chaudum! |
chaudum
force-pushed
the
chaudum/remove-validity-from-fifo
branch
from
b1690b5
to
f13e556
Compare
|
Hey @KMiller-Grafana, could I get a review of the (small) docs changes I did on this PR so we can merge it? |
chaudum
force-pushed
the
chaudum/remove-validity-from-fifo
branch
from
f13e556
to
7f00665
Compare
KMiller-Grafana
previously requested changes
Jan 27, 2022
We can remove the validity setting of 1h in 2.4 for the chunks cache because it doesn't reduce memory usage and instead leads to valid chunks being ignore when querying the cache. Chunks are immutable so it doesn't make sense to not return them if they are present in the cache. Closes #4922 Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
As described in #4921 this PR adds a periodic task that prunes expired items from the FIFO cache to free up memory. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
chaudum
force-pushed
the
chaudum/remove-validity-from-fifo
branch
from
b2751bd
to
891229c
Compare
owen-d
approved these changes
Jan 31, 2022
lxwzy
added a commit
to lxwzy/loki
that referenced
this pull request
Jul 9, 2022
As grafana#5148 changed, the deprecated is fifocache.duration, not fifocache.interval.
4 tasks
lxwzy
added a commit
to lxwzy/loki
that referenced
this pull request
Nov 7, 2022
As grafana#5148 changed, the deprecated is fifocache.duration, not fifocache.interval.
5 tasks
MichelHollands
pushed a commit
that referenced
this pull request
Nov 7, 2022
…ed (#7609) **What this PR does / why we need it**: I configured fifo cache with `validity` option (which is [deprecated](https://github.com/grafana/loki/blob/b92f113cb0961b628b643f4f3f9fddc1c18ed921/docs/sources/configuration/_index.md?plain=1#L2004) in v2.6.0, `fifocache.duration` as an flag) and loki print that: ``` level=warn ts=2022-07-08T17:01:30.134251284Z caller=fifo_cache.go:125 msg="running with DEPRECATED flag fifocache.interval, use fifocache.ttl instead" cache=frontend.fifocache ``` However, there is no flag `fifocache.interval`. As #5148 changed, the deprecated flag should be `fifocache.duration`, not `fifocache.interval`.
changhyuni
pushed a commit
to changhyuni/loki
that referenced
this pull request
Nov 8, 2022
…ed (grafana#7609) **What this PR does / why we need it**: I configured fifo cache with `validity` option (which is [deprecated](https://github.com/grafana/loki/blob/b92f113cb0961b628b643f4f3f9fddc1c18ed921/docs/sources/configuration/_index.md?plain=1#L2004) in v2.6.0, `fifocache.duration` as an flag) and loki print that: ``` level=warn ts=2022-07-08T17:01:30.134251284Z caller=fifo_cache.go:125 msg="running with DEPRECATED flag fifocache.interval, use fifocache.ttl instead" cache=frontend.fifocache ``` However, there is no flag `fifocache.interval`. As grafana#5148 changed, the deprecated flag should be `fifocache.duration`, not `fifocache.interval`.
Abuelodelanada
pushed a commit
to canonical/loki
that referenced
this pull request
Dec 1, 2022
…ed (grafana#7609) **What this PR does / why we need it**: I configured fifo cache with `validity` option (which is [deprecated](https://github.com/grafana/loki/blob/b92f113cb0961b628b643f4f3f9fddc1c18ed921/docs/sources/configuration/_index.md?plain=1#L2004) in v2.6.0, `fifocache.duration` as an flag) and loki print that: ``` level=warn ts=2022-07-08T17:01:30.134251284Z caller=fifo_cache.go:125 msg="running with DEPRECATED flag fifocache.interval, use fifocache.ttl instead" cache=frontend.fifocache ``` However, there is no flag `fifocache.interval`. As grafana#5148 changed, the deprecated flag should be `fifocache.duration`, not `fifocache.interval`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Addresses the problem of the FIFO cache where items become stale due to the validity setting but are never purged, as described in #4921
Which issue(s) this PR fixes:
Fixes #4921
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.