Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding error in fluentd client #5163

Merged
merged 2 commits into from
Jan 17, 2022

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Jan 17, 2022

What this PR does / why we need it:
This change fixes a bug that is caused by incorrectly trying to encode
any values other than string.

Which issue(s) this PR fixes:

Fixes #5099

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

@chaudum chaudum requested a review from a team as a code owner January 17, 2022 13:14
This change fixes a bug that is caused by incorrectly trying to encode
any values other than string.
This bug was a regression introduced with #5107 and caused
`NoMethodError` errors.

Fixes #5099

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum force-pushed the chaudum/fluentd-fix-encoding-error branch from d6f6691 to 9f3b364 Compare January 17, 2022 13:20
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 17, 2022
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 985e965 into main Jan 17, 2022
@cyriltovena cyriltovena deleted the chaudum/fluentd-fix-encoding-error branch January 17, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When log line from fluentd contains non-UTF-8 characters, the whole log line is dropped in Loki
2 participants