Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle context cancellation in some of the querier store.index-cache-read. #5178

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

liguozhong
Copy link
Contributor

level=error ts=2022-01-17T11:56:24.310460077Z caller=redis_cache.go:37 msg="failed to get from redis" name=chunksredis err="context canceled"

image
image

@liguozhong liguozhong requested a review from a team as a code owner January 19, 2022 02:08
@liguozhong
Copy link
Contributor Author

liguozhong commented Jan 19, 2022

@kavirajk This PR is the same as the PR you submitted, it is a missing function.
https://github.com/grafana/loki/pull/5080/files

func (c *seriesStore) GetChunkRefs()

Copy link
Collaborator

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @liguozhong 👍

Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeepsukhani sandeepsukhani merged commit 6c85cda into grafana:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants