Changed logic of handling RPC error with code Cancelled #5297
Conversation
…r with code 'Cancelled' happened. it's made to allow loki to retry the request to the querier instead of returning '499 The request was cancelled by the client.' back to the client.
|
Please make sure to include a section in the upgrade guide regarding this change; this is a change to an external interface, and could cause some unexpected behaviour for users. |
done. |
@dannykopping the bug was introduce before we release it. So we're fixing it back to how it was. |
Ah, my bad |
vlad-diachenko
force-pushed
the
mapped_grpc_cancellation_error_to_internal_server_error
branch
from
05d22d4
to
95c58a8
Compare
|
@cyriltovena @owen-d @dannykopping could somebody please merge it |
dannykopping
deleted the
mapped_grpc_cancellation_error_to_internal_server_error
branch
…r with code 'Cancelled' happened. it's made to allow loki to retry the request to the querier instead of returning '499 The request was cancelled by the client.' back to the client. (grafana#5297)
What this PR does / why we need it:
changed logic to respond with '500 Internal Server Error' if RPC error with code 'Cancelled' happened. it's made to allow Loki to retry the request to the querier instead of returning '499 The request was canceled by the client.' back to the client.
Which issue(s) this PR fixes:
Fixes #4991
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.