fix a panic in index-gateway caused by double closing of a channel #5298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
requested changes
Feb 2, 2022
chaudum
reviewed
Feb 2, 2022
chaudum
approved these changes
Feb 2, 2022
|
Thanks for the review and approval @chaudum! |
sandeepsukhani
added a commit
that referenced
this pull request
Feb 2, 2022
sandeepsukhani
added a commit
to sandeepsukhani/loki
that referenced
this pull request
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When
getOrCreateIndexSetmethod is called concurrently, the caller who is creating the index set should be the only one calling itsInitfunction. I did a mistake in not returning the index set from the callers who found the index set already and continuing with initialization. This PR fixes the issue by avoiding callingInitfunction on index sets multiple times.