Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better logic for when to shard wrt disabled lookback #5303

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Better logic for when to shard wrt disabled lookback #5303

merged 1 commit into from
Feb 2, 2022

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Feb 2, 2022

Now that the sharding lookback is optional, it makes more sense to shard when the lookback is disabled. This also helps prevent not sharding due to small clock skew issues where the lookback=0 but the time.Now()-lookback is less than the end of the request.

@owen-d owen-d requested a review from a team as a code owner February 2, 2022 15:33
slim-bean
slim-bean approved these changes Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit a88ee16 into grafana:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@owen-d @slim-bean