Experimental TSDB index #5376
Experimental TSDB index #5376
Conversation
|
I also added tsdb testware and the small diff from the only commit we were missing: prometheus/prometheus#9766 |
There was a problem hiding this comment.
Got to this a bit late. I have to say, the commit structure is great, I'll be making an effort to do similar going forward. Given that we're only really using this via tests ATM I only had one comment.
I also have one question; can you confirm which commit you copied tsdb/index and tsdb/querier from, and that you only modified tsdb/index? I see that in follow up commits, but I don't see any modifications to tsdb/querier yet. Is that correct?
| return &Builder{streams: make(map[string]*stream)} | ||
| } | ||
|
|
||
| func (b *Builder) AddSeries(ls labels.Labels, chks []ChunkMeta) { |
There was a problem hiding this comment.
would AddChunks make more sense?
There was a problem hiding this comment.
Yeah, I think that would be totally reasonable too. re; commits, thanks! I tried to keep these isolated, but I should have made an initial PR with just the forked code. 262b64b is the forking commit.
|
ref #5428 |
This PR retrofits TSDB for use with Loki. This is highly experimental and unused by the rest of the project, but can be used as foundations for a slimmer, more tailored index.
All the commits are standalone and I suggest reviewers approach them one at a time.