Align usage report config with Grafana #5406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
chaudum
reviewed
Feb 16, 2022
owen-d
approved these changes
Feb 17, 2022
| @@ -261,7 +261,7 @@ func New(cfg Config) (*Loki, error) { | |||
| Cfg: cfg, | |||
| clientMetrics: chunk_storage.NewClientMetrics(), | |||
| } | |||
|
|
|||
| usagestats.Edition("oss") | |||
There was a problem hiding this comment.
nit: I feel this would be better in RegisterFlags
There was a problem hiding this comment.
I plan to overrides this in enterprise and I need a way to know when it happens hence why I move it inside the New here. So I can override after New.
Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
|
/cc @KMiller-Grafana can you take a look on the doc side? |
KMiller-Grafana
suggested changes
Feb 24, 2022
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
|
@KMiller-Grafana let me know if we're good to merge this one, thanks ! |
KMiller-Grafana
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com
What this PR does / why we need it:
This PR update the config flag to use something similar as Grafana, this way users will be able to find the config to disable more easily.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
cc @KMiller-Grafana let's me know what you want to change on the doc side.
Checklist
CHANGELOG.mdabout the changes.