Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set match_max_concurrent true by default #5435

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Conversation

slim-bean
Copy link
Collaborator

Signed-off-by: Edward Welch edward.welch@grafana.com

What this PR does / why we need it:

We enable parallelism by default now it makes sense to me to enable match_max_concurrent: true by default such that to control a queriers parallelism you only need to adjust:

querier:
  max_concurrent: 10

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

Signed-off-by: Edward Welch <edward.welch@grafana.com>
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are changing a default, can you please add a note in the upgrade guide?

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean slim-bean merged commit 4ca1fd0 into main Feb 21, 2022
@slim-bean slim-bean deleted the match-max-concurrent branch February 21, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants