Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra param in call for inflightRequests metric #5507

Merged

Conversation

MichelHollands
Copy link
Contributor

@MichelHollands MichelHollands commented Mar 2, 2022

What this PR does / why we need it:

The call to update the inflightRequests metric incorrectly adds a "user" argument which seems to be used as a label name. This causes a run time panic as it only expects the label value:

10:22:22 enterprise-logs: panic: inconsistent label cardinality: expected 1 label values but got 2 in []string{"user", "test_instance"}
10:22:22 enterprise-logs: goroutine 966 [running]:
10:22:22 enterprise-logs: github.com/prometheus/client_golang/prometheus.(*GaugeVec).WithLabelValues(0x28933e0, {0xc0015fb9c0, 0xc001a24510, 0xc0001022d0})

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

Signed-off-by: Michel Hollands michel.hollands@grafana.com

Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
@MichelHollands MichelHollands changed the title Remove extra param in call to metric Remove extra param in call for inflightRequests metric Mar 2, 2022
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
@MichelHollands MichelHollands marked this pull request as ready for review March 2, 2022 10:39
@MichelHollands MichelHollands requested a review from a team as a code owner March 2, 2022 10:39
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants