Update vectorAggEvaluator to fail for expressions without grouping #5544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssncferreira
force-pushed
the
logql_evaluator_nil_check
branch
from
fab79ce
to
6612e97
Compare
cyriltovena
reviewed
Mar 4, 2022
| @@ -217,6 +217,9 @@ func vectorAggEvaluator( | |||
| expr *VectorAggregationExpr, | |||
| q Params, | |||
| ) (StepEvaluator, error) { | |||
| if expr.Grouping == nil { | |||
There was a problem hiding this comment.
Where does it panic, it's possible to have no groups for vector and range vector operation ?
There was a problem hiding this comment.
It panics if a VectorAggregationExpr is created with Grouping as nil. The VectorAggregationExpr should always have a Grouping, even in a simple expression without grouping. Therefore, this should never happen, but it is still possible that a VectorAggregationExpr is created without a Grouping, so this seems a good safe check.
I came up with this problem in the Split by range epic when creating a VectorAggregationExpr from a RangeAggregationExpr, because the former always needs a grouping but the latter has the grouping set to nil. The solution is here: 0c291f1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update the
vectorAggEvaluatorto return an error if the vector aggregator expression has a nilGroupingproperty, in order to avoid a nil pointer panic.Which issue(s) this PR fixes:
NA
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.