Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening/closing this PR for visibility.
@cyriltovena and I had guessed that embedding the label hash (fingerprint) into TSDB would be a net gain for read speeds, but after implementing it, that does not seem the case:
I'd guess this is because most of our time is spent on other operations which eclipse the potential benefit of this, such as growing slices in
GetChunkRefs
:ref #5428