Promtail: Fix retry/stop when erroring for out of cloudflare retention range (e.g. over 168 hours old) #5698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@dannykopping or @jeschkies not sure about the recent test failure appears to be a cleanup issue with that one run, any way to restart it without changing something in code? |
cstyan
reviewed
Mar 23, 2022
|
@dannykopping, @cstyan or @jeschkies anything else you need me to do to accept this? |
dannykopping
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
LGTM, will merge once CI completes.
Thanks for your patience on this one @paullryan and for the fix!
jeschkies
approved these changes
Mar 29, 2022
|
CI has completed, but GH is not acknowledging its completion; merging in spite of this... |
|
@dannykopping thank you for working with me to complete this will be very helpful in my org. |
slim-bean
added
the
backport release-2.5.x
splitice
pushed a commit
to X4BNet/loki
that referenced
this pull request
May 21, 2022
…n range (e.g. over 168 hours old) (grafana#5698) (grafana#5782) * fix: 5696 don't retry when out of range for cloudflare (cherry picked from commit 4e3f3b7) Co-authored-by: Paul Ryan <paul@campgroundbooking.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes the new cloudflare scrape in promtail for when loki tries to pull logs that are older than 168 hours, this is not allowed by the cloudflare api and right now is causing loki to stop reading logs in the future instead of ignoring and moving on.
Which issue(s) this PR fixes:
Fixes #5696
Special notes for your reviewer:
@cyriltovena I'm unsure if I missed a case here, please let me know.
Checklist
CHANGELOG.mdabout the changes.