Promtail: Rename config name limit_config to limits_config #5707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kavirajk
approved these changes
Mar 24, 2022
|
Merging this PR as the original config |
slim-bean
added
the
backport release-2.5.x
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-5707-to-release-2.5.x origin/release-2.5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x d67306b657c10c6c6d19fec6855ef7babfc48755
# Push it to GitHub
git push --set-upstream origin backport-5707-to-release-2.5.x
git switch main
# Remove the local backport branch
git branch -D backport-5707-to-release-2.5.xThen, create a pull request where the |
slim-bean
pushed a commit
that referenced
this pull request
Apr 6, 2022
* Rename promtail config name 'limit_config' to 'limits_config' * Add changelog entry * Fix formatting (cherry picked from commit d67306b)
slim-bean
added a commit
that referenced
this pull request
Apr 6, 2022
splitice
pushed a commit
to X4BNet/loki
that referenced
this pull request
May 21, 2022
) (grafana#5788) * Rename promtail config name 'limit_config' to 'limits_config' * Add changelog entry * Fix formatting (cherry picked from commit d67306b) Co-authored-by: Franz Wong <franzwong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Make configuration name consistent
Which issue(s) this PR fixes:
Fixes #5703
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.