Tsdb/compaction #5783
Merged
Tsdb/compaction #5783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… InclusiveBounds helper
sandeepsukhani
approved these changes
Apr 7, 2022
pkg/storage/tsdb/index/builder.go
Outdated
| ) | ||
| } | ||
|
|
||
| func (i Identifier) Combine(parentDir string) string { |
There was a problem hiding this comment.
Should we call it Filepath or BuildFilepath?
There was a problem hiding this comment.
Yeah, I like that better. Will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a first pass at a TSDB compactor. It also standardizes the names of TSDB files to the format
"index-${from}-${through}-${checksum}.tsdb". It combines multiple TSDB files and dedupes their contents where appropriate.To do this, I've added a
Checksum() uint32method where appropriate (IndexReaderandTSDBIndex).For added performance, I also moved the
[]ChunkMetaspool into the underlyingtsdb/indexpackage although it's still exported and used by thetsdbpackage as well as theindexpackage now.ref #5428