Add UDP transport option to Promtail's syslog target #5790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
commented
Apr 8, 2022
chaudum
commented
Apr 8, 2022
|
I still need to investigate some issues I discovered when benchmarking UDP transport, so I put the PR back to draft. |
|
This is really great! We are running promtail on hundreds of servers and recently activated syslog assuming UDP was supported. This will be a fantastic feature and saves running rsyslog (or similar software) just to forward UDP syslogs. |
chaudum
force-pushed
the
chaudum/syslog-udp-transport
branch
from
4955a03
to
4c0b3f3
Compare
chaudum
force-pushed
the
chaudum/syslog-udp-transport
branch
3 times, most recently
from
bab67a8
to
9974849
Compare
cyriltovena
approved these changes
May 2, 2022
Until now, the syslog target in Promtail did only support TCP. This PR adds support for sending syslog messages to Promtail (via ng-syslog or rsyslog) via UDP. UPD for syslogs can be used if you prefer speed over guaranteed delivery. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
force-pushed
the
chaudum/syslog-udp-transport
branch
from
9974849
to
9e65982
Compare
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Until now, the syslog target in Promtail did only support TCP. This PR adds support for sending syslog messages to Promtail (via ng-syslog or rsyslog) via UDP.
UPD for syslogs can be used if you prefer speed over guaranteed delivery.
Which issue(s) this PR fixes:
Fixes #5370
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.