Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promtail: Add ActiveTargets method #5839

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Apr 8, 2022

What this PR does / why we need it:

This PR adds ActiveTargets method propagating the activate targets of targetManager of
a Promtail instance. This method is useful for grafana/agent#1582 to know
in order to fetch all active targets of a given promtail instance.

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

@marctc marctc requested a review from a team as a code owner April 8, 2022 14:20
@CLAassistant
Copy link

CLAassistant commented Apr 8, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds reasonable. LGTM 👍

@kavirajk kavirajk merged commit 0315102 into main Apr 11, 2022
@kavirajk kavirajk deleted the add_active_targets_promtail branch April 11, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants