Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Correct bad links in the best practice docs #5934

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Docs: Correct bad links in the best practice docs #5934

merged 1 commit into from
Apr 18, 2022

Conversation

johgsc
Copy link
Contributor

@johgsc johgsc commented Apr 15, 2022

What this PR does / why we need it:
changed URLs for Fluentd and Fluent Bit since the old URLs where leading to a 404 on GitHub.

Which issue(s) this PR fixes:
Fixes #
I think there is none

Special notes for your reviewer:
This is my first ever PR in an Open Source project. I hope I have done it right :)

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

changed URLs for [Fluentd](https://github.com/grafana/loki/tree/main/clients/cmd/fluentd) and [Fluent Bit](https://github.com/grafana/loki/tree/main/clients/cmd/fluent-bit) since the old URLs where leading to a 404 on GitHub.
@CLAassistant
Copy link

CLAassistant commented Apr 15, 2022

CLA assistant check
All committers have signed the CLA.

@johgsc johgsc mentioned this pull request Apr 15, 2022
3 tasks
Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the link corrections.

@KMiller-Grafana KMiller-Grafana changed the title Docs: Changed URLs which leaded into a 404 in the best practice docs Docs: Correct bad links in the best practice docs Apr 15, 2022
@kavirajk kavirajk merged commit 27a5367 into grafana:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants