Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fluentd): allow fluentd_thread label to be configurable #6240

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

taharah
Copy link
Contributor

@taharah taharah commented May 25, 2022

Signed-off-by: Trevor Wood Trevor.G.Wood@gmail.com

What this PR does / why we need it:

This PR allows the fluentd_thread label included when multi-threading flushing is enabled to be configurable. The label will be included by default in order to preserve backwards compatibility.

Which issue(s) this PR fixes:
Fixes #5336

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md -- N/A

@taharah taharah requested review from KMiller-Grafana and a team as code owners May 25, 2022 00:56
@CLAassistant
Copy link

CLAassistant commented May 25, 2022

CLA assistant check
All committers have signed the CLA.

@taharah taharah force-pushed the fix-labels branch 2 times, most recently from b178529 to 5462205 Compare May 25, 2022 00:57
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

Signed-off-by: Trevor Wood <Trevor.G.Wood@gmail.com>
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea presented here looks good to me, but I'm not ruby expert :( . Now that loki accepts out of order data by default, this label isn't necessary in most scenarios.

cc @cyriltovena hopefully can give you an approval as well.

@owen-d owen-d merged commit 0470e4e into grafana:main Jun 2, 2022
@taharah taharah deleted the fix-labels branch June 2, 2022 19:22
@osg-grafana osg-grafana added type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories and removed area/docs labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Fluentd flush thread labels to be configurable
5 participants